Netsyms/Mods-for-HESK-Netsyms
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add strongly typed constructor args on BusinessLogic layer

Browse Source
This commit is contained in:
Mike Koch 2017-09-07 20:31:57 -04:00
parent f700addda5
commit 7ca00fecbe
No known key found for this signature in database
GPG Key ID: 9BA5D7F8391455ED
22 changed files with 50 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/BusinessLogic/Attachments/AttachmentHandler.php
View File

@ -33,7 +33,11 @@ class AttachmentHandler {
/* @var $userToTicketChecker UserToTicketChecker */
private $userToTicketChecker;
function __construct($ticketGateway, $attachmentGateway, $fileWriter, $userToTicketChecker, $fileDeleter) {
function __construct(TicketGateway $ticketGateway,
AttachmentGateway $attachmentGateway,
FileWriter $fileWriter,
UserToTicketChecker $userToTicketChecker,
FileDeleter $fileDeleter) {
$this->ticketGateway = $ticketGateway;
$this->attachmentGateway = $attachmentGateway;
$this->fileWriter = $fileWriter;

5
api/BusinessLogic/Categories/CategoryHandler.php
View File

@ -26,7 +26,10 @@ class CategoryHandler {
/* @var $modsForHeskSettingsGateway ModsForHeskSettingsGateway */
private $modsForHeskSettingsGateway;
function __construct($categoryGateway, $ticketGateway, $permissionChecker, $modsForHeskSettingsGateway) {
function __construct(CategoryGateway $categoryGateway,
TicketGateway $ticketGateway,
PermissionChecker $permissionChecker,
ModsForHeskSettingsGateway $modsForHeskSettingsGateway) {
$this->categoryGateway = $categoryGateway;
$this->ticketGateway = $ticketGateway;
$this->permissionChecker = $permissionChecker;

3
api/BusinessLogic/Categories/CategoryRetriever.php
View File

@ -17,7 +17,8 @@ class CategoryRetriever {
*/
private $modsForHeskSettingsGateway;
function __construct($categoryGateway, $modsForHeskSettingsGateway) {
function __construct(CategoryGateway $categoryGateway,
ModsForHeskSettingsGateway $modsForHeskSettingsGateway) {
$this->categoryGateway = $categoryGateway;
$this->modsForHeskSettingsGateway = $modsForHeskSettingsGateway;
}

4
api/BusinessLogic/Emails/EmailSenderHelper.php
View File

@ -21,7 +21,9 @@ class EmailSenderHelper {
*/
private $mailgunEmailSender;
function __construct($emailTemplateParser, $basicEmailSender, $mailgunEmailSender) {
function __construct(EmailTemplateParser $emailTemplateParser,
BasicEmailSender $basicEmailSender,
MailgunEmailSender $mailgunEmailSender) {
$this->emailTemplateParser = $emailTemplateParser;
$this->basicEmailSender = $basicEmailSender;
$this->mailgunEmailSender = $mailgunEmailSender;

6
api/BusinessLogic/Emails/EmailTemplateParser.php
View File

@ -35,7 +35,10 @@ class EmailTemplateParser {
*/
private $emailTemplateRetriever;
function __construct($statusGateway, $categoryGateway, $userGateway, $emailTemplateRetriever) {
function __construct(StatusGateway $statusGateway,
CategoryGateway $categoryGateway,
UserGateway $userGateway,
EmailTemplateRetriever $emailTemplateRetriever) {
$this->statusGateway = $statusGateway;
$this->categoryGateway = $categoryGateway;
$this->userGateway = $userGateway;
@ -50,6 +53,7 @@ class EmailTemplateParser {
* @param $modsForHeskSettings array
* @return ParsedEmailProperties
* @throws InvalidEmailTemplateException
* @throws \Exception
*/
function getFormattedEmailForLanguage($templateId, $languageCode, $ticket, $heskSettings, $modsForHeskSettings) {
global $hesklang;

6
api/BusinessLogic/Emails/ParsedEmailProperties.php
View File

@ -1,10 +1,4 @@
<?php
/**
* Created by PhpStorm.
* User: mkoch
* Date: 2/28/2017
* Time: 9:36 PM
*/
namespace BusinessLogic\Emails;

2
api/BusinessLogic/Navigation/CustomNavElementHandler.php
View File

@ -10,7 +10,7 @@ class CustomNavElementHandler {
/* @var $customNavElementGateway CustomNavElementGateway */
private $customNavElementGateway;
function __construct($customNavElementGateway) {
function __construct(CustomNavElementGateway $customNavElementGateway) {
$this->customNavElementGateway = $customNavElementGateway;
}

2
api/BusinessLogic/Security/BanRetriever.php
View File

@ -11,7 +11,7 @@ class BanRetriever {
*/
private $banGateway;
function __construct($banGateway) {
function __construct(BanGateway $banGateway) {
$this->banGateway = $banGateway;
}

2
api/BusinessLogic/Security/UserContextBuilder.php
View File

@ -14,7 +14,7 @@ class UserContextBuilder {
*/
private $userGateway;
function __construct($userGateway) {
function __construct(UserGateway $userGateway) {
$this->userGateway = $userGateway;
}

2
api/BusinessLogic/Security/UserToTicketChecker.php
View File

@ -10,7 +10,7 @@ class UserToTicketChecker {
/* @var $userGateway UserGateway */
private $userGateway;
function __construct($userGateway) {
function __construct(UserGateway $userGateway) {
$this->userGateway = $userGateway;
}

2
api/BusinessLogic/Settings/ApiChecker.php
View File

@ -9,7 +9,7 @@ class ApiChecker {
/* @var $modsForHeskSettingsGateway ModsForHeskSettingsGateway */
private $modsForHeskSettingsGateway;
function __construct($modsForHeskSettingsGateway) {
function __construct(ModsForHeskSettingsGateway $modsForHeskSettingsGateway) {
$this->modsForHeskSettingsGateway = $modsForHeskSettingsGateway;
}

2
api/BusinessLogic/Settings/SettingsRetriever.php
View File

@ -9,7 +9,7 @@ class SettingsRetriever {
/* @var $modsForHeskSettingsGateway ModsForHeskSettingsGateway */
private $modsForHeskSettingsGateway;
function __construct($modsForHeskSettingsGateway) {
function __construct(ModsForHeskSettingsGateway $modsForHeskSettingsGateway) {
$this->modsForHeskSettingsGateway = $modsForHeskSettingsGateway;
}

2
api/BusinessLogic/Statuses/StatusRetriever.php
View File

@ -10,7 +10,7 @@ class StatusRetriever {
/* @var $statusGateway StatusGateway */
private $statusGateway;
function __construct($statusGateway) {
function __construct(StatusGateway $statusGateway) {
$this->statusGateway = $statusGateway;
}

3
api/BusinessLogic/Tickets/Autoassigner.php
View File

@ -15,7 +15,8 @@ class Autoassigner {
/* @var $userGateway UserGateway */
private $userGateway;
function __construct($categoryGateway, $userGateway) {
function __construct(CategoryGateway $categoryGateway,
UserGateway $userGateway) {
$this->categoryGateway = $categoryGateway;
$this->userGateway = $userGateway;
}

4
api/BusinessLogic/Tickets/NewTicketValidator.php
View File

@ -24,7 +24,9 @@ class NewTicketValidator {
*/
private $ticketValidators;
function __construct($categoryRetriever, $banRetriever, $ticketValidators) {
function __construct(CategoryRetriever $categoryRetriever,
BanRetriever $banRetriever,
TicketValidators $ticketValidators) {
$this->categoryRetriever = $categoryRetriever;
$this->banRetriever = $banRetriever;
$this->ticketValidators = $ticketValidators;

11
api/BusinessLogic/Tickets/TicketCreator.php
View File

@ -56,8 +56,15 @@ class TicketCreator {
/* @var $modsForHeskSettingsGateway ModsForHeskSettingsGateway */
private $modsForHeskSettingsGateway;
function __construct($newTicketValidator, $trackingIdGenerator, $autoassigner, $statusGateway, $ticketGateway,
$verifiedEmailChecker, $emailSenderHelper, $userGateway, $modsForHeskSettingsGateway) {
function __construct(NewTicketValidator $newTicketValidator,
TrackingIdGenerator $trackingIdGenerator,
Autoassigner $autoassigner,
StatusGateway $statusGateway,
TicketGateway $ticketGateway,
VerifiedEmailChecker $verifiedEmailChecker,
EmailSenderHelper $emailSenderHelper,
UserGateway $userGateway,
ModsForHeskSettingsGateway $modsForHeskSettingsGateway) {
$this->newTicketValidator = $newTicketValidator;
$this->trackingIdGenerator = $trackingIdGenerator;
$this->autoassigner = $autoassigner;

4
api/BusinessLogic/Tickets/TicketDeleter.php
View File

@ -20,7 +20,9 @@ class TicketDeleter {
/* @var $attachmentHandler AttachmentHandler */
private $attachmentHandler;
function __construct($ticketGateway, $userToTicketChecker, $attachmentHandler) {
function __construct(TicketGateway $ticketGateway,
UserToTicketChecker $userToTicketChecker,
AttachmentHandler $attachmentHandler) {
$this->ticketGateway = $ticketGateway;
$this->userToTicketChecker = $userToTicketChecker;
$this->attachmentHandler = $attachmentHandler;

3
api/BusinessLogic/Tickets/TicketEditor.php
View File

@ -22,7 +22,8 @@ class TicketEditor {
/* @var $userToTicketChecker UserToTicketChecker */
private $userToTicketChecker;
function __construct($ticketGateway, $userToTicketChecker) {
function __construct(TicketGateway $ticketGateway,
UserToTicketChecker $userToTicketChecker) {
$this->ticketGateway = $ticketGateway;
$this->userToTicketChecker = $userToTicketChecker;
}

3
api/BusinessLogic/Tickets/TicketRetriever.php
View File

@ -19,7 +19,8 @@ class TicketRetriever {
/* @var $userToTicketChecker UserToTicketChecker */
private $userToTicketChecker;
function __construct($ticketGateway, $userToTicketChecker) {
function __construct(TicketGateway $ticketGateway,
UserToTicketChecker $userToTicketChecker) {
$this->ticketGateway = $ticketGateway;
$this->userToTicketChecker = $userToTicketChecker;
}

2
api/BusinessLogic/Tickets/TicketValidators.php
View File

@ -10,7 +10,7 @@ class TicketValidators {
*/
private $ticketGateway;
function __construct($ticketGateway) {
function __construct(TicketGateway $ticketGateway) {
$this->ticketGateway = $ticketGateway;
}

2
api/BusinessLogic/Tickets/TrackingIdGenerator.php
View File

@ -12,7 +12,7 @@ class TrackingIdGenerator {
*/
private $ticketGateway;
function __construct($ticketGateway) {
function __construct(TicketGateway $ticketGateway) {
$this->ticketGateway = $ticketGateway;
}

2
api/BusinessLogic/Tickets/VerifiedEmailChecker.php
View File

@ -17,7 +17,7 @@ class VerifiedEmailChecker {
*/
private $verifiedEmailGateway;
function __construct($verifiedEmailGateway) {
function __construct(VerifiedEmailGateway $verifiedEmailGateway) {
$this->verifiedEmailGateway = $verifiedEmailGateway;
}