Fix typo

create_function has been DEPRECATED as of PHP 7.2.0

.gitignore

@@ -5,3 +5,4 @@ coverage_report
 !.idea/runConfigurations/
 .DS_Store
 live_phpunit.sh
+/nbproject/private/

.idea/runConfigurations/All_Unit_Tests.xml

@@ -0,0 +1,6 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="All Unit Tests" type="PHPUnitRunConfigurationType" factoryName="PHPUnit">
+    <TestRunner class="pdt256\Shipping\PackageDimensionsValidationTrait" configuration_file="$PROJECT_DIR$/phpunit.xml" directory="$PROJECT_DIR$" file="$PROJECT_DIR$/tests/PackageDimensionsValidationTrait.php" scope="XML" use_alternative_configuration_file="true" />
+    <method v="2" />
+  </configuration>
+</component>

.travis.yml

@@ -1,6 +1,9 @@
 language: php
 php:
   - 7.1
+  - 7.2
+  - 7.3
+  - 7.4
 
 before_script:
   - composer install --prefer-dist

LICENSE.txt

@@ -1,6 +1,7 @@
 The MIT License (MIT)
 
 Copyright (c) 2014 Jamie Isaacs <pdt256@gmail.com>
+Copyright (c) 2020 Netsyms Technologies <opensource@netsyms.com>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -15,19 +15,6 @@ Multiple packages can be added to get additional rates.
 All code (including tests) conform to the PSR-2 coding standards.
 The namespace and autoloader are using the PSR-4 standard.
 
-All pull requests are processed by Travis CI to conform to PSR-2 and to verify all unit tests pass. 
-
-## Installation
-
-Add the following lines to your ``composer.json`` file.
-
-```JSON
-{
-    "require": {
-        "pdt256/shipping": "1.0.*"
-    }
-}
-```
 
 ## Example
 

composer.json

@@ -1,5 +1,5 @@
 {
-    "name": "pdt256/shipping",
+    "name": "netsyms/shippingrates",
     "description": "Shipping Rate API",
     "license": "MIT",
     "keywords": ["ship", "ups", "usps", "fedex"],
@@ -7,16 +7,20 @@
         {
             "name": "Jamie Isaacs",
             "email": "pdt256@gmail.com"
+        },
+        {
+            "name": "Netsyms Technologies",
+            "email": "opensource@netsyms.com"
         }
     ],
     "extra": {
         "branch-alias": {
-            "dev-master": "1.0.0"
+            "dev-master": "1.0.x-dev"
         }
     },
     "require-dev": {
-        "phpunit/phpunit": "4.0.*",
-        "squizlabs/php_codesniffer": "1.5.5"
+        "phpunit/phpunit": "7.0.*",
+        "squizlabs/php_codesniffer": "3.5.*"
     },
     "require": {
         "php": ">=7.1"

nbproject/project.properties

@@ -0,0 +1,22 @@
+auxiliary.org-netbeans-modules-php-phpunit.bootstrap_2e_create_2e_tests=false
+auxiliary.org-netbeans-modules-php-phpunit.bootstrap_2e_enabled=false
+auxiliary.org-netbeans-modules-php-phpunit.bootstrap_2e_path=
+auxiliary.org-netbeans-modules-php-phpunit.configuration_2e_enabled=false
+auxiliary.org-netbeans-modules-php-phpunit.configuration_2e_path=
+auxiliary.org-netbeans-modules-php-phpunit.customSuite_2e_enabled=false
+auxiliary.org-netbeans-modules-php-phpunit.customSuite_2e_path=
+auxiliary.org-netbeans-modules-php-phpunit.phpUnit_2e_enabled=false
+auxiliary.org-netbeans-modules-php-phpunit.phpUnit_2e_path=
+auxiliary.org-netbeans-modules-php-phpunit.test_2e_groups_2e_ask=false
+auxiliary.org-netbeans-modules-php-phpunit.test_2e_run_2e_all=false
+auxiliary.org-netbeans-modules-php-phpunit.test_2e_run_2e_phpunit_2e_only=false
+file.reference.ShippingRates-tests=tests
+include.path=${php.global.include.path}
+php.version=PHP_73
+source.encoding=UTF-8
+src.dir=src
+tags.asp=false
+tags.short=false
+test.src.dir=${file.reference.ShippingRates-tests}
+testing.providers=PhpUnit
+web.root=.

nbproject/project.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://www.netbeans.org/ns/project/1">
+    <type>org.netbeans.modules.php.project</type>
+    <configuration>
+        <data xmlns="http://www.netbeans.org/ns/php-project/1">
+            <name>ShippingRates</name>
+        </data>
+    </configuration>
+</project>

phpunit.xml

@@ -14,4 +14,9 @@
             <directory suffix=".php">./tests</directory>
         </testsuite>
     </testsuites>
+    <filter>
+        <whitelist>
+            <directory>./src</directory>
+        </whitelist>
+    </filter>
 </phpunit>

src/Package.php

@@ -1,35 +1,63 @@
-<?php namespace pdt256\Shipping;
+<?php
 
-class Package
-{
-    protected $weight;
+namespace pdt256\Shipping;
+
+class Package {
+
+    protected $pounds;
+    protected $ounces;
     protected $width;
     protected $length;
     protected $height;
 
-    /**
-     * @return mixed
-     */
-    public function getWeight()
-    {
-        return $this->weight;
+    public function getWeight() {
+        $weight = 0;
+        if (!empty($this->getPounds())) {
+            $weight += $this->getPounds();
+        }
+        if (!empty($this->getOunces())) {
+            $weight += ($this->getOunces() / 16);
+        }
+        if ($weight == 0) {
+            return null;
+        }
+        return $weight;
+    }
+
+    public function getPounds() {
+        return $this->pounds ?? 0;
+    }
+
+    public function getOunces() {
+        return $this->ounces ?? 0;
+    }
+
+    public function setWeight($pounds) {
+        return $this->setPounds($pounds)->setOunces(0);
     }
 
     /**
-     * @param mixed $weight
+     * @param mixed $pounds
      * @return $this
      */
-    public function setWeight($weight)
-    {
-        $this->weight = $weight;
+    public function setPounds($pounds) {
+        $this->pounds = $pounds;
+        return $this;
+    }
+
+    /**
+     * @param mixed $ounces
+     * @return $this
+     */
+    public function setOunces($ounces) {
+        $this->ounces = $ounces;
         return $this;
     }
 
     /**
      * @return mixed
      */
-    public function getWidth()
-    {
+    public function getWidth() {
         return $this->width;
     }
 
@@ -37,8 +65,7 @@ class Package
      * @param mixed $width
      * @return $this
      */
-    public function setWidth($width)
-    {
+    public function setWidth($width) {
         $this->width = $width;
         return $this;
     }
@@ -46,8 +73,7 @@ class Package
     /**
      * @return mixed
      */
-    public function getLength()
-    {
+    public function getLength() {
         return $this->length;
     }
 
@@ -55,8 +81,7 @@ class Package
      * @param mixed $length
      * @return $this
      */
-    public function setLength($length)
-    {
+    public function setLength($length) {
         $this->length = $length;
         return $this;
     }
@@ -64,8 +89,7 @@ class Package
     /**
      * @return mixed
      */
-    public function getHeight()
-    {
+    public function getHeight() {
         return $this->height;
     }
 
@@ -73,9 +97,9 @@ class Package
      * @param mixed $height
      * @return $this
      */
-    public function setHeight($height)
-    {
+    public function setHeight($height) {
         $this->height = $height;
         return $this;
     }
+
 }

src/RateAdapter.php

@@ -1,8 +1,6 @@
 <?php
 namespace pdt256\Shipping;
 
-use Exception;
-
 abstract class RateAdapter
 {
     protected $isProduction;
@@ -18,20 +16,25 @@ abstract class RateAdapter
 
     /**
      * Make sure all necessary fields are set
+     * @return self
      */
     abstract protected function validate();
+
     /**
      * Prepare XML
+     * @return self
      */
     abstract protected function prepare();
 
     /**
      * Curl Request
+     * @return self
      */
     abstract protected function execute();
 
     /**
      * Convert to shipping rates array
+     * @return self
      */
     abstract protected function process();
 
@@ -71,17 +74,20 @@ abstract class RateAdapter
         return $this->shipment;
     }
 
-    public function setIsProduction($isProduction)
+    public function setIsProduction($isProduction): void
     {
         $this->isProduction = $isProduction;
     }
 
-    public function getIsProduction()
+    public function getIsProduction(): bool
     {
         return $this->isProduction;
     }
 
-    public function getRates()
+    /**
+     * @return Quote[]
+     */
+    public function getRates(): array
     {
         $this
             ->validate()
@@ -93,8 +99,10 @@ abstract class RateAdapter
         return array_values($this->rates);
     }
 
-    protected function sortByCost()
+    protected function sortByCost(): void
     {
-        uasort($this->rates, create_function('$a, $b', 'return ($a->getCost() > $b->getCost());'));
+        uasort($this->rates, static function (Quote $a, Quote $b) {
+            return ($a->getCost() > $b->getCost());
+        });
     }
 }

src/RateRequest/Adapter.php

@@ -3,8 +3,8 @@ namespace pdt256\Shipping\RateRequest;
 
 abstract class Adapter
 {
-    protected $curlConnectTimeoutInMilliseconds = 1000;
-    protected $curlDownloadTimeoutInSeconds = 11;
+    protected $curlConnectTimeoutInMilliseconds = 1500;
+    protected $curlDownloadTimeoutInSeconds = 50;
 
     abstract public function execute($url, $data = null);
 }

src/Ship.php

@@ -139,8 +139,10 @@ class Ship
         return $display_rates;
     }
 
-    protected function sortByCost(& $rates)
+    protected function sortByCost(&$rates)
     {
-        uasort($rates, create_function('$a, $b', 'return ($a->getCost() > $b->getCost());'));
+        uasort($rates, function ($a, $b) {
+            return ($a->getCost() > $b->getCost());
+        });
     }
 }

src/UPS/Rate.php

@@ -95,8 +95,8 @@ class Rate extends RateAdapter
         ]);
 
         $this->setRequestAdapter(Arr::get($options, 'requestAdapter', new RateRequest\Post()));
-
     }
+
     protected function validate()
     {
         $this->validatePackages();

src/USPS/Rate.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace pdt256\Shipping\USPS;
 
 use pdt256\Shipping;
@@ -10,18 +11,17 @@ use pdt256\Shipping\Validator;
 use DOMDocument;
 use Exception;
 
-class Rate extends RateAdapter
-{
+class Rate extends RateAdapter {
+
     private $urlDev = 'http://production.shippingapis.com/ShippingAPI.dll';
     private $urlProd = 'http://production.shippingapis.com/ShippingAPI.dll';
-
     private $username;
     private $password;
+
     /**
      * Codes of appropriate shipping types. Default value is specified in __construct.
      */
     public $approvedCodes;
-
     private $shipping_codes = [
         'domestic' => [
             '00' => 'First-Class Mail Parcel',
@@ -67,20 +67,19 @@ class Rate extends RateAdapter
         ],
     ];
 
-    public function __construct($options = [])
-    {
+    public function __construct($options = []) {
         parent::__construct($options);
 
         $this->username = Arr::get($options, 'username');
         $this->password = Arr::get($options, 'password');
         $this->approvedCodes = Arr::get($options, 'approvedCodes', [
-            '1',
-            '4',
+                    '1',
+                    '4',
         ]);
         $this->setRequestAdapter(Arr::get($options, 'requestAdapter', new RateRequest\Get()));
     }
-    protected function validate()
-    {
+
+    protected function validate() {
         $this->validatePackages();
         Validator::checkIfNull($this->username, 'username');
         Validator::checkIfNull($this->password, 'password');
@@ -89,8 +88,8 @@ class Rate extends RateAdapter
 
         return $this;
     }
-    protected function prepare()
-    {
+
+    protected function prepare() {
         $packages = '';
         $sequence_number = 0;
         foreach ($this->shipment->getPackages() as $p) {
@@ -119,33 +118,30 @@ class Rate extends RateAdapter
                 $container = 'VARIABLE';
             }
 
-            $packages .=
-                '<Package ID="' . $sequence_number . '">' .
+            $packages .= '<Package ID="' . $sequence_number . '">' .
                     '<Service>ALL</Service>' .
                     '<ZipOrigination>' . $this->shipment->getFromPostalCode() . '</ZipOrigination>' .
                     '<ZipDestination>' . $this->shipment->getToPostalCode() . '</ZipDestination>' .
-                    '<Pounds>' . $p->getWeight() . '</Pounds>' .
-                    '<Ounces>0</Ounces>' .
+                    '<Pounds>' . $p->getPounds() . '</Pounds>' .
+                    '<Ounces>' . $p->getOunces() . '</Ounces>' .
                     '<Container>' . $container . '</Container>' .
                     '<Size>' . $size . '</Size>' .
                     '<Width>' . $p->getWidth() . '</Width>' .
                     '<Length>' . $p->getLength() . '</Length>' .
                     '<Height>' . $p->getHeight() . '</Height>' .
                     '<Machinable>' . 'False' . '</Machinable>' .
-                '</Package>';
+                    '</Package>';
         }
 
-        $this->data =
-            '<RateV4Request USERID="' . $this->username . '">' .
+        $this->data = '<RateV4Request USERID="' . $this->username . '">' .
                 '<Revision/>' .
                 $packages .
-            '</RateV4Request>';
+                '</RateV4Request>';
 
         return $this;
     }
 
-    protected function execute()
-    {
+    protected function execute() {
         if ($this->isProduction) {
             $url = $this->urlProd;
         } else {
@@ -159,8 +155,7 @@ class Rate extends RateAdapter
         return $this;
     }
 
-    protected function process()
-    {
+    protected function process() {
         try {
             $dom = new DOMDocument('1.0', 'UTF-8');
             $dom->loadXml($this->response);
@@ -195,10 +190,10 @@ class Rate extends RateAdapter
 
             $quote = new Quote;
             $quote
-                ->setCarrier('usps')
-                ->setCode($code)
-                ->setName($name)
-                ->setCost((int) $cost);
+                    ->setCarrier('usps')
+                    ->setCode($code)
+                    ->setName($name)
+                    ->setCost((int) $cost);
 
             $rates[$quote->getCode()] = $quote;
         }
@@ -207,4 +202,5 @@ class Rate extends RateAdapter
 
         return $this;
     }
+
 }

tests/ArrTest.php

@@ -1,7 +1,9 @@
 <?php
 namespace pdt256\Shipping;
 
-class ArrTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class ArrTest extends TestCase
 {
     public function providerGet()
     {

tests/Fedex/FedexTest.php

@@ -7,8 +7,9 @@ use pdt256\Shipping\Package;
 use pdt256\Shipping\Shipment;
 use pdt256\Shipping\Quote;
 use DateTime;
+use PHPUnit\Framework\TestCase;
 
-class RateTest extends \PHPUnit_Framework_TestCase
+class RateTest extends TestCase
 {
     /** @var Shipment */
     protected $shipment;
@@ -182,6 +183,5 @@ class RateTest extends \PHPUnit_Framework_TestCase
             'requestAdapter' => new StubFedex,
         ]);
         $rateAdapter->getRates();
-
     }
 }

tests/PackageDimensionsValidationTrait.php

@@ -5,8 +5,9 @@ namespace pdt256\Shipping;
 use pdt256\Shipping\RateRequest\StubFedex;
 use pdt256\Shipping\RateRequest\StubUPS;
 use pdt256\Shipping\RateRequest\StubUSPS;
+use PHPUnit\Framework\TestCase;
 
-class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
+class PackageDimensionsValidationTrait extends TestCase
 {
     protected function getNormalPackage()
     {
@@ -107,12 +108,15 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
          ->addPackage($package);
         $adapter->setShipment($shipment);
         $adapter->getRates();
+
+        $this->assertEquals($shipment, $adapter->getShipment());
     }
 
     public function testNormalUSPS()
     {
         $this->validatePackage($this->getNormalPackage(), $this->getUSPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -120,6 +124,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoHeightPackage(), $this->getUSPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -127,6 +132,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoLengthPackage(), $this->getUSPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -134,6 +140,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoWidthPackage(), $this->getUSPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -147,6 +154,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNormalPackage(), $this->getUPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -154,6 +162,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoHeightPackage(), $this->getUPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -161,6 +170,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoLengthPackage(), $this->getUPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -168,6 +178,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoWidthPackage(), $this->getUPSAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -181,6 +192,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNormalPackage(), $this->getFedexAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -188,6 +200,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoHeightPackage(), $this->getFedexAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -195,6 +208,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoLengthPackage(), $this->getFedexAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */
@@ -202,6 +216,7 @@ class PackageDimensionsValidationTrait extends \PHPUnit_Framework_TestCase
     {
         $this->validatePackage($this->getNoWidthPackage(), $this->getFedexAdapter());
     }
+
     /**
      * @expectedException \LogicException
      */

tests/PackageTest.php

@@ -1,7 +1,9 @@
 <?php
 namespace pdt256\Shipping;
 
-class PackageTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class PackageTest extends TestCase
 {
     public function testCreate()
     {
@@ -12,8 +14,16 @@ class PackageTest extends \PHPUnit_Framework_TestCase
         $package->setHeight(8);
 
         $this->assertEquals(5, $package->getWeight());
+        $this->assertEquals(5, $package->getPounds());
+        $this->assertEquals(0, $package->getOunces());
         $this->assertEquals(6, $package->getWidth());
         $this->assertEquals(7, $package->getLength());
         $this->assertEquals(8, $package->getHeight());
+
+        $package->setPounds(3);
+        $package->setOunces(4);
+        $this->assertEquals(3, $package->getPounds());
+        $this->assertEquals(4, $package->getOunces());
+        $this->assertEquals(3.25, $package->getWeight());
     }
 }

tests/QuoteTest.php

@@ -2,8 +2,9 @@
 namespace pdt256\Shipping;
 
 use DateTime;
+use PHPUnit\Framework\TestCase;
 
-class QuoteTest extends \PHPUnit_Framework_TestCase
+class QuoteTest extends TestCase
 {
     public function testCreate()
     {

tests/RateAdapterTest.php

@@ -1,13 +0,0 @@
-<?php
-namespace pdt256\Shipping;
-
-class RateAdapterTest extends \PHPUnit_Framework_TestCase
-{
-    public function testCreate()
-    {
-        /* @var RateAdapter $mock */
-        $mock = $this->getMockForAbstractClass('pdt256\Shipping\RateAdapter');
-        $mockRequestAdapter = $this->getMockForAbstractClass('pdt256\Shipping\RateRequest\Adapter');
-        $mock->setRequestAdapter($mockRequestAdapter);
-    }
-}

tests/ShipTest.php

@@ -2,8 +2,9 @@
 namespace pdt256\Shipping;
 
 use DateTime;
+use PHPUnit\Framework\TestCase;
 
-class ShipTest extends \PHPUnit_Framework_TestCase
+class ShipTest extends TestCase
 {
     /** @var Shipment */
     public $shipment;

tests/ShipmentTest.php

@@ -1,7 +1,9 @@
 <?php
 namespace pdt256\Shipping;
 
-class ShipmentTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+
+class ShipmentTest extends TestCase
 {
     public function testCreate()
     {

tests/UPS/RateTest.php

@@ -6,8 +6,9 @@ use pdt256\Shipping\Ship;
 use pdt256\Shipping\Package;
 use pdt256\Shipping\Shipment;
 use pdt256\Shipping\Quote;
+use PHPUnit\Framework\TestCase;
 
-class RateTest extends \PHPUnit_Framework_TestCase
+class RateTest extends TestCase
 {
     /** @var Shipment */
     protected $shipment;

tests/USPS/RateTest.php

@@ -6,8 +6,9 @@ use pdt256\Shipping\Ship;
 use pdt256\Shipping\Package;
 use pdt256\Shipping\Shipment;
 use pdt256\Shipping\Quote;
+use PHPUnit\Framework\TestCase;
 
-class RateTest extends \PHPUnit_Framework_TestCase
+class RateTest extends TestCase
 {
     /** @var Shipment */
     protected $shipment;

tests/ValidatorTest.php

@@ -1,7 +1,10 @@
 <?php
 namespace pdt256\Shipping;
 
-class ValidatorTest extends \PHPUnit_Framework_TestCase
+use PHPUnit\Framework\TestCase;
+use stdClass;
+
+class ValidatorTest extends TestCase
 {
     /**
      * @expectedException \LogicException
@@ -15,8 +18,9 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase
     {
         Validator::checkIfNull('XXX', 'notNullValue');
         Validator::checkIfNull([], 'notNullValue');
-        Validator::checkIfNull(new \stdClass(), 'notNullValue');
+        Validator::checkIfNull(new stdClass(), 'notNullValue');
         Validator::checkIfNull(function () {
         }, 'notNullValue');
+        $this->assertTrue(true);
     }
 }