2
0
mirror of https://github.com/Ionaru/easy-markdown-editor synced 2025-07-31 13:54:28 -06:00

more code cleanup for readibilty

This commit is contained in:
Steve 2021-03-15 20:08:38 -07:00
parent 8702dd22d0
commit 25db654cf0

View File

@ -333,9 +333,12 @@ function toggleFullScreen(editor) {
var sidebyside = cm.getWrapperElement().nextSibling; var sidebyside = cm.getWrapperElement().nextSibling;
// if (/editor-preview-active-side/.test(sidebyside.className)) { // if non-fullscreen side-by-side is allowed, then pass along "dontToggle" flag
toggleSideBySide(editor, true); var dontToggleSideBySide = editor.options.sideBySideFullscreen === false;
// }
if (/editor-preview-active-side/.test(sidebyside.className) || dontToggleSideBySide) {
toggleSideBySide(editor, dontToggleSideBySide);
}
if (editor.options.onToggleFullScreen) { if (editor.options.onToggleFullScreen) {
editor.options.onToggleFullScreen(cm.getOption('fullScreen') || false); editor.options.onToggleFullScreen(cm.getOption('fullScreen') || false);
@ -871,21 +874,16 @@ function redo(editor) {
/** /**
* Toggle side by side preview. * Toggle side by side preview.
* Note: If triggered by fullscreen toggle and sideBySideFullscreen === false,
* `sideBySide` is not actually toggled, but classes are reapplied as needed.
* @param {EasyMDE} editor - The EasyMDE object * @param {EasyMDE} editor - The EasyMDE object
* @param {boolean} triggeredByFullscreenToggle If triggered by fullscreen toggle. * @param {boolean} dontToggle Flag for cleaning up side effects of fullScreen toggle.
*/ */
function toggleSideBySide(editor, triggeredByFullscreenToggle) { function toggleSideBySide(editor, dontToggle) {
var cm = editor.codemirror; var cm = editor.codemirror;
var wrapper = cm.getWrapperElement(); var wrapper = cm.getWrapperElement();
var preview = wrapper.nextSibling; var preview = wrapper.nextSibling;
var toolbarButton = editor.toolbarElements && editor.toolbarElements['side-by-side']; var toolbarButton = editor.toolbarElements && editor.toolbarElements['side-by-side'];
var useSideBySideListener = false; var useSideBySideListener = false;
// if triggered by fullscreen toggle and sideBySideFullscreen === false, don't toggle
var dontToggle = editor.options.sideBySideFullscreen === false && triggeredByFullscreenToggle;
var noFullscreenItems = [ var noFullscreenItems = [
wrapper.parentNode, // easyMDEContainer wrapper.parentNode, // easyMDEContainer
editor.gui.toolbar, editor.gui.toolbar,