From 2a904b24ab8e083d0d2eb00b45fee1c170e995ef Mon Sep 17 00:00:00 2001 From: Joh Dokler Date: Wed, 9 Dec 2020 11:58:57 +0100 Subject: [PATCH 1/2] Fix the sideBySideFullscreen=false + status=false bug --- src/js/easymde.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/js/easymde.js b/src/js/easymde.js index b9aa609..fbd121e 100644 --- a/src/js/easymde.js +++ b/src/js/easymde.js @@ -909,7 +909,9 @@ function toggleSideBySide(editor) { if (editor.options.sideBySideFullscreen === false) { cm.setOption('sideBySideNoFullscreen', true); noFullscreenItems.forEach(function(el) { - addNoFullscreenClass(el); + if (el) { + addNoFullscreenClass(el); + }; }); } else { toggleFullScreen(editor); @@ -2142,7 +2144,7 @@ EasyMDE.prototype.render = function (el) { assignImageBlockAttributes(parentEl, window.EMDEimagesCache[keySrc]); } } - } + } }); } this.codemirror.on('update', function () { From c428a37ee333989dc56a4145895df44599979a6a Mon Sep 17 00:00:00 2001 From: Joh Dokler Date: Wed, 9 Dec 2020 12:08:15 +0100 Subject: [PATCH 2/2] Fix additional edge case for the sideBySideFullscreen=false + status=false bug --- src/js/easymde.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/js/easymde.js b/src/js/easymde.js index fbd121e..9df761b 100644 --- a/src/js/easymde.js +++ b/src/js/easymde.js @@ -883,9 +883,11 @@ function toggleSideBySide(editor) { } function removeNoFullscreenClass(el) { - el.className = el.className.replace( - /\s*sided--no-fullscreen\s*/g, '' - ); + if (el != null) { + el.className = el.className.replace( + /\s*sided--no-fullscreen\s*/g, '' + ); + } } if (/editor-preview-active-side/.test(preview.className)) { @@ -909,9 +911,9 @@ function toggleSideBySide(editor) { if (editor.options.sideBySideFullscreen === false) { cm.setOption('sideBySideNoFullscreen', true); noFullscreenItems.forEach(function(el) { - if (el) { + if (el != null) { addNoFullscreenClass(el); - }; + } }); } else { toggleFullScreen(editor);