Netsyms/easy-markdown-editor
2
0
Fork 0
mirror of https://github.com/Ionaru/easy-markdown-editor synced 2025-08-12 03:32:44 -06:00
Code Issues Releases Wiki Activity

Small fixes for this change

Browse Source 
* Removed redundant code.
* Renamed function to better reflect its behaviour.
* Marked `noDisable` and `noMobile` as optional.
This commit is contained in:
Jeroen Akkerman 2019-02-20 01:59:54 +01:00
parent 4385d733e5
commit f50c96bc01
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dist/easymde.min.js vendored
View File

File diff suppressed because one or more lines are too long

12
src/js/easymde.js
View File

@ -113,9 +113,9 @@ function fixShortcut(name) {
/** /**
* Create icon element for toolbar. * Create button element for toolbar.
*/ */
function createIcon(options, enableTooltips, shortcuts) { function createToolbarButton(options, enableTooltips, shortcuts) {
options = options || {}; options = options || {};
var el = document.createElement('button'); var el = document.createElement('button');
el.className = options.name; el.className = options.name;
@ -131,11 +131,11 @@ function createIcon(options, enableTooltips, shortcuts) {
} }
} }
if (options.noDisable || options.className.indexOf('no-disable') !== -1) { if (options.noDisable) {
el.classList.add('no-disable'); el.classList.add('no-disable');
} }
if (options.noMobile || options.className.indexOf('no-mobile') !== -1) { if (options.noMobile) {
el.classList.add('no-mobile'); el.classList.add('no-mobile');
} }
@ -159,7 +159,7 @@ function createIcon(options, enableTooltips, shortcuts) {
var icon = document.createElement('i'); var icon = document.createElement('i');
for (var iconClassIndex = 0; iconClassIndex < iconClasses.length; iconClassIndex++) { for (var iconClassIndex = 0; iconClassIndex < iconClasses.length; iconClassIndex++) {
var iconClass = iconClasses[iconClassIndex]; var iconClass = iconClasses[iconClassIndex];
icon.classList.add(iconClass) icon.classList.add(iconClass);
} }
el.appendChild(icon); el.appendChild(icon);
@ -1841,7 +1841,7 @@ EasyMDE.prototype.createToolbar = function (items) {
if (item === '|') { if (item === '|') {
el = createSep(); el = createSep();
} else { } else {
el = createIcon(item, self.options.toolbarTips, self.options.shortcuts); el = createToolbarButton(item, self.options.toolbarTips, self.options.shortcuts);
} }
// bind events, special for info // bind events, special for info

4
types/easymde.d.ts vendored
View File

@ -81,8 +81,8 @@ declare namespace EasyMDE {
action: string|((editor: EasyMDE) => void); action: string|((editor: EasyMDE) => void);
className: string; className: string;
title: string; title: string;
noDisable: boolean; noDisable?: boolean;
noMobile: boolean; noMobile?: boolean;
} }
interface Options { interface Options {