From 62fbc156146d7bd7e71c15b60e2e12fde14930c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaime=20Marqui=CC=81nez=20Ferra=CC=81ndiz?= Date: Sat, 14 Mar 2015 22:39:00 +0100 Subject: [PATCH] [YoutubeDL] extract_info: Default 'download' to False That's what I would expect from the method name --- test/test_download.py | 2 +- youtube_dl/YoutubeDL.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_download.py b/test/test_download.py index 6a149ae4f..77fdb4e9a 100644 --- a/test/test_download.py +++ b/test/test_download.py @@ -136,7 +136,7 @@ def generator(test_case): # We're not using .download here sine that is just a shim # for outside error handling, and returns the exit code # instead of the result dict. - res_dict = ydl.extract_info(test_case['url']) + res_dict = ydl.extract_info(test_case['url'], download=True) except (DownloadError, ExtractorError) as err: # Check if the exception is not a network related one if not err.exc_info[0] in (compat_urllib_error.URLError, socket.timeout, UnavailableVideoError, compat_http_client.BadStatusLine) or (err.exc_info[0] == compat_HTTPError and err.exc_info[1].code == 503): diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py index e779fc9a8..560d92bfa 100755 --- a/youtube_dl/YoutubeDL.py +++ b/youtube_dl/YoutubeDL.py @@ -629,7 +629,7 @@ class YoutubeDL(object): for key, value in extra_info.items(): info_dict.setdefault(key, value) - def extract_info(self, url, download=True, ie_key=None, extra_info={}, + def extract_info(self, url, download=False, ie_key=None, extra_info={}, process=True): ''' Returns a list with a dictionary for each video we find. @@ -1449,7 +1449,7 @@ class YoutubeDL(object): for url in url_list: try: # It also downloads the videos - res = self.extract_info(url) + res = self.extract_info(url, download=True) except UnavailableVideoError: self.report_error('unable to download video') except MaxDownloadsReached: