forth changes accoring to forth review by @yan12125 at github pull #1468

This commit is contained in:
scil 2018-01-10 23:45:56 +08:00
parent d3ebb04895
commit 3c4c17a7ed

View File

@ -61,10 +61,6 @@ class XimalayaIE(XimalayaBaseIE):
'name': 'cover_url',
'url': r're:^https?://.*\.jpg$',
},
{
'name': 'cover_url_142',
'url': r're:^https?://.*\.jpg$',
},
{
'name': 'cover_url_142',
'url': r're:^https?://.*\.jpg$',
@ -155,7 +151,7 @@ class XimalayaIE(XimalayaBaseIE):
audio_description_file = '%s://www.ximalaya.com/sounds/%s/rich_intro' % (scheme, audio_id)
audio_description = self._download_webpage(audio_description_file, audio_id,
note='Downloading description file %s' % audio_description_file,
errnote='Unable to download descrip file, try to parse web page',
errnote='Unable to download descrip file',
fatal=False)
audio_description = audio_description.strip() if audio_description else None
@ -163,11 +159,11 @@ class XimalayaIE(XimalayaBaseIE):
'id': audio_id,
'uploader': audio_info.get('nickname'),
'uploader_id': audio_uploader_id,
'uploader_url': self._USER_URL_FORMAT % (scheme, audio_uploader_id),
'uploader_url': self._USER_URL_FORMAT % (scheme, audio_uploader_id) if audio_uploader_id else None,
'title': audio_info['title'],
'thumbnails': thumbnails,
'description': audio_description,
'categories': list((audio_info.get('category_name'), audio_info.get('category_title'))),
'categories': list(filter(None, (audio_info.get('category_name'), audio_info.get('category_title')))),
'duration': audio_info.get('duration'),
'view_count': audio_info.get('play_count'),
'like_count': audio_info.get('favorites_count'),
@ -235,5 +231,3 @@ class XimalayaAlbumIE(XimalayaBaseIE):
XimalayaIE.ie_key(),
mobj.group('id'),
mobj.group('title'))