R-yan/l1ving_youtube-dl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[YoutubeDL] extract_info: Default 'download' to False

Browse Source 
That's what I would expect from the method name
This commit is contained in:
Jaime Marquínez Ferrándiz 2015-03-14 22:39:00 +01:00
parent 7c42327e0e
commit 62fbc15614
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/test_download.py
View File

@ -136,7 +136,7 @@ def generator(test_case):
# We're not using .download here sine that is just a shim # We're not using .download here sine that is just a shim
# for outside error handling, and returns the exit code # for outside error handling, and returns the exit code
# instead of the result dict. # instead of the result dict.
res_dict = ydl.extract_info(test_case['url']) res_dict = ydl.extract_info(test_case['url'], download=True)
except (DownloadError, ExtractorError) as err: except (DownloadError, ExtractorError) as err:
# Check if the exception is not a network related one # Check if the exception is not a network related one
if not err.exc_info[0] in (compat_urllib_error.URLError, socket.timeout, UnavailableVideoError, compat_http_client.BadStatusLine) or (err.exc_info[0] == compat_HTTPError and err.exc_info[1].code == 503): if not err.exc_info[0] in (compat_urllib_error.URLError, socket.timeout, UnavailableVideoError, compat_http_client.BadStatusLine) or (err.exc_info[0] == compat_HTTPError and err.exc_info[1].code == 503):

4
youtube_dl/YoutubeDL.py
View File

@ -629,7 +629,7 @@ class YoutubeDL(object):
for key, value in extra_info.items(): for key, value in extra_info.items():
info_dict.setdefault(key, value) info_dict.setdefault(key, value)
def extract_info(self, url, download=True, ie_key=None, extra_info={}, def extract_info(self, url, download=False, ie_key=None, extra_info={},
process=True): process=True):
''' '''
Returns a list with a dictionary for each video we find. Returns a list with a dictionary for each video we find.
@ -1449,7 +1449,7 @@ class YoutubeDL(object):
for url in url_list: for url in url_list:
try: try:
# It also downloads the videos # It also downloads the videos
res = self.extract_info(url) res = self.extract_info(url, download=True)
except UnavailableVideoError: except UnavailableVideoError:
self.report_error('unable to download video') self.report_error('unable to download video')
except MaxDownloadsReached: except MaxDownloadsReached: