R-yan/l1ving_youtube-dl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #342 from aviperes/bugfix_facebook_comment_count

Browse Source 
fix facebook comments count
This commit is contained in:
aviperetz34 2020-06-24 10:05:22 +03:00 committed by GitHub
commit 9f1a1ea3bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
test/ci/test_facebook.py
View File

@ -3,25 +3,40 @@ import youtube_dl
class facebookMetaData(unittest.TestCase): class facebookMetaData(unittest.TestCase):
def test_metadata_fetch(self): def test_likes_metadata(self):
params = {} params = {}
url = "https://www.facebook.com/iihfhockey/videos/2742345396033296/" url = "https://www.facebook.com/iihfhockey/videos/2742345396033296/"
ydl = youtube_dl.YoutubeDL(params) ydl = youtube_dl.YoutubeDL(params)
info = ydl.extract_info(url, download=False) info = ydl.extract_info(url, download=False)
self.assertTrue(info.has_key('like_count')) self.assertGreater(info.get('like_count'), 200)
self.assertTrue(info.has_key('reactions_count'))
def _test_metadata_fetch_with_log_in(self): def test_reactions_metadata(self):
url = "https://www.facebook.com/iihfhockey/videos/2742345396033296/" params = {}
url = "https://www.facebook.com/supercarblondie/videos/519426815548240/"
ydl = youtube_dl.YoutubeDL(params)
info = ydl.extract_info(url, download=False)
self.assertGreater(info.get('reactions_count'), 1000000)
self.assertGreater(info.get('like_count'), 800000)
def test_comments_live_video(self):
params = {}
url = "https://www.facebook.com/Medianetlive/videos/676754012901513/"
ydl = youtube_dl.YoutubeDL(params)
info = ydl.extract_info(url, download=False)
self.assertGreater(info.get('comment_count'), 0)
def test_metadata_fetch_with_log_in(self):
url = "https://www.facebook.com/SerieA/videos/282581803097269"
params = {} params = {}
with open("cookie_file") as file: with open("cookie_file") as file:
proxy = "ec2-35-175-164-238.compute-1.amazonaws.com:3128" proxy = "ec2-3-221-82-67.compute-1.amazonaws.com:3128"
params['cookiefile'] = file.name params['cookiefile'] = file.name
params['proxy'] = proxy params['proxy'] = proxy
ydl = youtube_dl.YoutubeDL(params) ydl = youtube_dl.YoutubeDL(params)
info = ydl.extract_info(url, download=False) info = ydl.extract_info(url, download=False)
self.assertTrue(info.get('timestamp')) self.assertTrue(info.get('timestamp'))
self.assertTrue(info.get('view_count')) self.assertTrue(info.get('view_count'))
self.assertTrue(info.get('comment_count'))
self.assertTrue(info.get('width')) self.assertTrue(info.get('width'))
self.assertTrue(info.get('uploader_id')) self.assertTrue(info.get('uploader_id'))
self.assertTrue(info.get('thumbnail')) self.assertTrue(info.get('thumbnail'))

8
youtube_dl/extractor/facebook.py
View File

@ -630,6 +630,14 @@ class FacebookIE(InfoExtractor):
if values: if values:
return values[-1] return values[-1]
value = self._search_regex(r'"commentCount":(.+?),', webpage, 'comment_count', fatal=False)
if value:
return value
value = self._search_regex(r'"commentcount":(.+?),', tahoe_data.secondary, 'comment_count', fatal=False)
if value:
return value
def _extract_views(self, webpage, tahoe_data): def _extract_views(self, webpage, tahoe_data):
value = self._extract_meta_count(['postViewCount', 'viewCount'], webpage, tahoe_data, 'likes') value = self._extract_meta_count(['postViewCount', 'viewCount'], webpage, tahoe_data, 'likes')
if value: if value: