From cc9cb3096e4e1a2f49a4a8a32cf3ebd0789fbaf2 Mon Sep 17 00:00:00 2001
From: sulyi <sulyi.gbox@gmail.com>
Date: Mon, 12 Dec 2016 14:08:29 +0100
Subject: [PATCH] [jsinterp] Reprioritizing TODOs in test_jsinterp_parser.py

---
 test/test_jsinterp_parser.py   | 53 ++++++++++++++++++++++++++++------
 youtube_dl/jsinterp/tstream.py |  1 +
 2 files changed, 45 insertions(+), 9 deletions(-)

diff --git a/test/test_jsinterp_parser.py b/test/test_jsinterp_parser.py
index 5c6a8389d..6c533b32d 100644
--- a/test/test_jsinterp_parser.py
+++ b/test/test_jsinterp_parser.py
@@ -733,7 +733,7 @@ class TestJSInterpreterParser(unittest.TestCase):
 
     @unittest.skip('Test not yet implemented: missing ast')
     def test_switch(self):
-        # TODO switch statement test
+        # ASAP switch statement test
         jsi = JSInterpreter(
             '''
             function a(x) {
@@ -755,24 +755,59 @@ class TestJSInterpreterParser(unittest.TestCase):
         ast = []
         self.assertEqual(list(jsi.statements()), ast)
 
-    @unittest.skip('Test not yet implemented: missing code and ast')
+    @unittest.skip('Test not yet implemented: missing ast')
     def test_for(self):
-        # TODO for statement test
-        # might be split up
-        jsi = JSInterpreter('')
+        # ASAP for statement test
+        jsi = JSInterpreter('''
+            function f(x){
+                for (var h = 0; h <= x; ++h) {
+                    a = h;
+                }
+                return a
+            }
+        ''')
+        ast = []
+        self.assertEqual(list(traverse(list(jsi.statements()))), list(traverse(ast)))
+
+    @unittest.skip('Test not yet implemented: missing ast')
+    def test_for_empty(self):
+        # ASAP for empty statement test
+        jsi = JSInterpreter('''
+            function f(){
+                var h = 0
+                for (; h < 2; ++h) {
+                    a = h;
+                }
+                return a
+            }
+        ''')
+        ast = []
+        self.assertEqual(list(traverse(list(jsi.statements()))), list(traverse(ast)))
+
+    @unittest.skip('Test not yet implemented: missing ast')
+    def test_for_in(self):
+        # ASAP for in statement test
+        jsi = JSInterpreter('''
+                function f(z){
+                    for (h in z) {
+                        a = h;
+                    }
+                    return a
+                }
+            ''')
         ast = []
         self.assertEqual(list(jsi.statements()), ast)
 
     @unittest.skip('Test not yet implemented: missing code and ast')
     def test_do(self):
-        # TODO do statement test
+        # ASAP do statement test
         jsi = JSInterpreter('')
         ast = []
         self.assertEqual(list(jsi.statements()), ast)
 
     @unittest.skip('Test not yet implemented: missing code and ast')
     def test_while(self):
-        # TODO while statement test
+        # ASAP while statement test
         jsi = JSInterpreter('')
         ast = []
         self.assertEqual(list(jsi.statements()), ast)
@@ -787,14 +822,14 @@ class TestJSInterpreterParser(unittest.TestCase):
 
     @unittest.skip('Test not yet implemented: missing code and ast')
     def test_funct_expr(self):
-        # TODO function expression test
+        # ASAP function expression test
         jsi = JSInterpreter('')
         ast = []
         self.assertEqual(list(jsi.statements()), ast)
 
     @unittest.skip('Test not yet implemented: missing code and ast')
     def test_object(self):
-        # TODO object literal test
+        # ASAP object literal test
         jsi = JSInterpreter('')
         ast = []
         self.assertEqual(list(jsi.statements()), ast)
diff --git a/youtube_dl/jsinterp/tstream.py b/youtube_dl/jsinterp/tstream.py
index a1a9afac0..d5f0cdfca 100644
--- a/youtube_dl/jsinterp/tstream.py
+++ b/youtube_dl/jsinterp/tstream.py
@@ -48,6 +48,7 @@ _RELATIONS = {
     '>': (Token.GT, operator.gt),
     '<=': (Token.LE, operator.le),
     '>=': (Token.GE, operator.ge),
+    # XXX add instanceof and in operators
     # XXX check python and JavaScript equality difference
     '==': (Token.EQ, operator.eq),
     '!=': (Token.NE, operator.ne),