R-yan/l1ving_youtube-dl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
17,483 Commits 2 Branches 1,077 Tags
Commit Graph

182 Commits

Author SHA1 Message Date
shin
17f82ec733 Mutagen is a required dependency. 2019-12-26 14:26:53 +05:30
shin
9556018388 Handle ImportError as a warning 2019-12-26 14:20:17 +05:30
shin
e40d476168 Use FFmpeg for embedding thumbnails into MP3 
Embedding thumbnails inside ID3v2 tags is done by FFmpeg quite nicely, there's no need to depend on the external dependency. Also, FFmpeg already used for many post-processing and conversion work.
 2019-12-26 14:09:15 +05:30
shin
edcaf554b0 Refactored the according according to 'flake8' 2019-12-26 13:43:50 +05:30
shin
6fb38337d6 Followed the code-convention of 'youtube-dl' 2019-12-26 13:18:13 +05:30
shin
e82a75d7e7 Throw exceptions if 'mutagen' cannot be found 2019-12-26 13:00:51 +05:30
shin
fd35c3fbaa MP4/M4A files use 'mutagen' for thumbnail embedding 
Previously, AtomicParsley was used to embed thumbnails into moov.udta.meta.ilst atom which contains iTunes style metadata for audio files. Using AtomicParsley for only embedding thumbnails was quite infiuriating.Mutagen can manipulate audio metadata and the module itself is quite lightweight and doesn't require any deps. I (shin-ts) favoured to have a package as addon instead of an executable, because this method is quite convinient in my opinion.
 2019-12-26 12:57:48 +05:30
Sergey M․
824fa51165
[utils] Improve subtitles_filename (closes #22753) 2019-10-18 04:03:53 +07:00
Sergey M․
3089bc748c
Fix W504 and disable W503 (closes #20863) 2019-05-11 03:57:40 +07:00
Sergey M․
ce52c7c111
[postprocessor/ffmpeg] Fix avconv processing broken in #19025 (closes #19067) 2019-01-30 06:15:23 +07:00
Sergey M․
61ff92e11e
[postprocessor/ffmpeg] Wrap loglevel args in encodeArgument 2019-01-29 01:59:56 +07:00
Sergey M
1397a790ff
[postprocessor/ffmpeg] Disable "Last message repeated" messages which cause non-zero exit status (#19025) 2019-01-28 22:59:00 +07:00
Tatsh
7f903dd8bf [postprocessor/ffmpeg] Do not copy Apple TV chapter tracks while embedding subtitles (closes #19042) 
Related issue: https://trac.ffmpeg.org/ticket/6016
 2019-01-28 22:57:14 +07:00
Andrew Udvare
2b3afe6b0f
[postprocessor/ffmpeg] Disable "Last message repeated" messages which cause non-zero exit status 2019-01-27 22:24:37 -05:00
Remita Amine
eb35b163ad [postprocessor/ffmpeg] fallback to ffmpeg/avconv for audio codec detection(closes #681) 2019-01-24 20:23:04 +01:00
Sergey M․
cbdc688c41
[postprocessor/ffmpeg] Relax ubuntu ffmpeg version regex 2019-01-12 00:30:06 +07:00
Sergey M․
5caa531a1a
[postprocessor/ffmpeg] PEP 8 2019-01-11 23:47:23 +07:00
Remita Amine
a64646e417 [postprocessor/ffmpeg] sanitize ffmpeg version for Ubuntu and Arch Linux systems(closes #18813) 2019-01-11 15:12:10 +01:00
Sergey M․
04fb6928da
[postprocessor/ffmpeg] Embed subtitles with non-standard language codes (refs #18765) 2019-01-07 00:57:55 +07:00
Sergey M․
d4a24f4091
Prefer ffmpeg over avconv by default (closes #8622) 2018-06-29 01:09:14 +07:00
Andrew Udvare
b5cbe3d652 [postprocessor/embedthumbnail] Skip embedding when there aren't any thumbnails 2018-02-25 19:33:13 +07:00
Sergey M․
7974e289a1
[postprocessor/xattr] Clarify NO_SPACE message (#14970) 2017-12-14 01:05:02 +07:00
Sergey M․
d2ae7e24e5
[postprocessor/ffmpeg] Convert to opus using libopus (closes #14381) 2017-10-02 04:43:25 +07:00
Yen Chi Hsuan
3869028ffb [utils] Use bytes-like objects in dfxp2srt 
This fixes handling of non-UTF8 TTML subtitles

Closes #14191
 2017-09-16 12:18:38 +08:00
Sergey M․
a02682fd13
Keep in sync with ffmpeg's current malformed AAC bitstream wording (closes #13587) 2017-07-09 17:09:44 +07:00
Sergey M․
8b6ac49ecc
[postprocessor/execafterdownload] Encode command line (closes #13407) 2017-06-17 23:16:53 +07:00
Sergey M․
be80986ed9
[postprocessor/metadatafromtitle] Fix missing optional meta fields (closes #13408) 2017-06-17 19:05:10 +07:00
Yen Chi Hsuan
5192ee17e7
[postprocessor/ffmpeg] Fix metadata filename handling on Python 2 
Fixes #13182
 2017-05-25 22:07:03 +08:00
Sergey M․
fa26734e07
[postprocessor/metadatafromtitle] Add support regex syntax for --metadata-from-title (closes #13065) 2017-05-14 00:03:15 +07:00
remitamine
fa2a36d9bc [ffmpeg] add support for chapters field postprocessing 2017-05-02 20:41:48 +01:00
Remita Amine
40fcba5edb improve coding style 2017-04-12 20:38:43 +01:00
Philipp Hagemeister
21bfcd3d6e [postprocessor/ffmpeg] Add support for flac 
Requested at http://stackoverflow.com/q/42828041/35070
 2017-03-16 12:50:45 +01:00
Sergey M․
0f57447de7
[postprocessor/ffmpeg] Add mising space (closes #12232) 2017-02-24 04:56:58 +07:00
Yen Chi Hsuan
ec85ded83c
Fix "invalid escape sequences" error on Python 3.6 2017-01-06 00:58:56 +08:00
Yen Chi Hsuan
8e2915d70b
Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails" 
This reverts commit 7360db05b43741c2dfa1fd024e9c2f013ed97c9e.

This commit was added as an attempt to fix #6046. Unfortunately, the fix
is completely wrong. As reported on #10359, embedded thumbnails are not
displayed in VLC, and Se7en on IRC reports that the embedded thumbnail
misleads mpv as well.

The correct way is using -attachment of ffmpeg, while the current
run_ffmpeg_multiple_files API can't handle it cleanly.
 2016-10-20 15:07:19 +08:00
Sergey M․
0b94dbb115
[postprocessor/ffmpeg] PEP 8 2016-10-16 19:16:47 +07:00
Pierre Mdawar
2273e2c530 [postprocessor/ffmpeg] Return correct filepath and ext in updated information in FFmpegExtractAudioPP 
Return correct audio's filepath and ext instead of the video's when extracting audio and audio file already exists.
 2016-10-16 02:12:03 +07:00
Déstin Reed
dcdb292fdd
Unify coding cookie 2016-10-03 23:44:29 +07:00
Yen Chi Hsuan
efa97bdcf1
Move write_xattr to utils.py 
There are some other places that use xattr functions. It's better to
move it to a common place so that others can use it.
 2016-09-30 00:28:32 +08:00
Remita Amine
30d9e20938 [postprocessor/ffmpeg] apply FFmpegFixupM3u8PP only for videos with aac codec(#5591) 2016-09-16 22:06:55 +01:00
Sergey M․
25dd58ca6a
[metadatafromtitle] Remove unused exception class 2016-08-09 04:01:05 +07:00
nyorain
5e42f8a0ad
Make --metadata-from-title non fatal 
Output a warning if the metadata can't be parsed from the title (and don't write any metadata) instead of raising a critical error.
 2016-08-09 03:56:22 +07:00
Yen Chi Hsuan
23495d6a39
Revert "[ffmpeg] Fix embedding subtitles (#9063)" 
This reverts commit ccff2c404d7ea9f5b21ede8ae57bb79feec7eb94.

Fixes #10081.

The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:

opts = [
    '-map', '0:v?',
    '-c:v', 'copy',
    '-map', '0:a?',
    '-c:a', 'copy',
    # other options...
]

Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
 2016-07-15 20:02:36 +08:00
Yen Chi Hsuan
5b6a74856b Merge pull request #9288 from reyyed/issue#9063fix 
[ffmpeg] Fix embedding subtitles (#9063)
 2016-07-09 14:29:53 +08:00
Yen Chi Hsuan
702ccf2dc0
[compat] Rename shlex_quote and remove unused subprocess_check_output 2016-05-10 16:00:21 +08:00
Sergey M․
4bd143a3a0
[postprocessor/ffmpeg] Simplify metadata preparation and add track related metafields (Closes #9357) 2016-05-01 10:56:54 +06:00
Wang Jun Tham
ccff2c404d [ffmpeg] Fix embedding subtitles (#9063) 
Changed command line parameters for ffmpeg when embedding subtitles.
Changed to ‘-map 0:v -c:v copy -map 0:a -c:a copy’
 2016-04-24 00:08:02 +08:00
remitamine
b9f2fdd37f [ffmpeg] Clarify rationale for pipe(-) exclusion in _ffmpeg_filename_argument 2016-04-16 21:50:13 +01:00
remitamine
d868f43c58 [ffmpeg] check for - file name in _ffmpeg_filename_argument 2016-04-16 19:45:56 +01:00
remitamine
0750b2491f [ffmpeg] try to convert tt subtitles usng dfxp2srt 2016-04-01 19:47:49 +01:00