skylarmt/postserve
1
0
Fork 0
Code Issues 6 Pull Requests 5 Releases Wiki Activity

support current ST_ASMVT parameters #9

Open
skylarmt wants to merge 3 commits from smellman/dev-postgis-2.5.1 into master
pull from: smellman/dev-postgis-2.5.1
merge into: skylarmt:master
Conversation 5 Commits 3 Files Changed 4 +11 -10
skylarmt commented 2019-02-17 21:22:49 -07:00
Owner
Copy Link

Author: @smellman

@sk1p comment me in https://github.com/openmaptiles/postgis/pull/10#issuecomment-464446991

I just make PR for postgis docker image and I update postserve to support current ST_ASMVT.
I will test with planet (importing time over 32hours).

Author: @smellman @sk1p comment me in https://github.com/openmaptiles/postgis/pull/10#issuecomment-464446991 I just make [PR for postgis docker image](https://github.com/openmaptiles/postgis/pull/11) and I update postserve to support current ST_ASMVT. I will test with planet (importing time over 32hours).
skylarmt commented 2019-03-21 18:11:09 -06:00
Author
Owner
Copy Link

Author: @nyurik

@smellman I actually had to do a full rewrite of this tool, see #11 -- it is far cleaner now,
without any locally done modifications. I won't merge it until I merge the proper SQL generation
into the openmaptiles repo.

Author: @nyurik @smellman I actually had to do a full rewrite of this tool, see #11 -- it is far cleaner now, without any locally done modifications. I won't merge it until I merge the proper SQL generation into the openmaptiles repo.
skylarmt commented 2019-03-21 21:55:05 -06:00
Author
Owner
Copy Link

Author: @smellman

I will close this PR and I will make new PR with support buffer-size property. Also, I have other problem so I research it now.

Author: @smellman I will close this PR and I will make new PR with support buffer-size property. Also, I have other problem so I research it now.
skylarmt commented 2019-03-21 22:03:15 -06:00
Author
Owner
Copy Link

Author: @nyurik

@smellman what do you mean by the buffer-size property? The buffer sizes are generated as part of the SQL generation -- because each layer has its own settings for the buffer sizes.

Author: @nyurik @smellman what do you mean by the buffer-size property? The buffer sizes are generated as part of the [SQL generation](https://github.com/openmaptiles/openmaptiles-tools/pull/34/files#diff-547b229652e18895a3c7488e08d66ac5R93) -- because each layer has its own settings for the buffer sizes.
skylarmt commented 2019-03-21 23:32:05 -06:00
Author
Owner
Copy Link

Author: @smellman

Yes, I just upload my WIP branch.
I found 0/0/0 problem when I test this branch.

Author: @smellman Yes, I just upload my [WIP branch](https://github.com/smellman/postserve/tree/dev-postgis-2.5.1-buffer-size-support). I found 0/0/0 problem when I test this branch.
skylarmt commented 2019-03-22 00:03:04 -06:00
Author
Owner
Copy Link

Author: @nyurik

@smellman could you paste your generated query to a gist? (as printed by your postserve when it starts) . This way it will be easier to compare just the SQL, and how it executes.

Author: @nyurik @smellman could you paste your generated query to a gist? (as printed by your postserve when it starts) . This way it will be easier to compare just the SQL, and how it executes.
This pull request has changes conflicting with the target branch.
  • server.py
  • Dockerfile
  • requirements.txt
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin smellman/dev-postgis-2.5.1:smellman/dev-postgis-2.5.1
git checkout smellman/dev-postgis-2.5.1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: skylarmt/postserve#9
No description provided.
Delete Branch "smellman/dev-postgis-2.5.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?